php.net/date links made functional #54205
Conversation
Either the link given is intended to work (it does by forwarding) - then it should be functional. Or not - then it should be replaced. Right?
|
👋 Thanks for your first Pull Request and for helping build the future of Gutenberg and WordPress, @karstengresch! In case you missed it, we'd love to have you join us in our Slack community, where we hold regularly weekly meetings open to anyone to coordinate with each other. If you want to learn more about WordPress development in general, check out the Core Handbook full of helpful information. |
There was a problem hiding this comment.
@karstengresch Thanks for the PR.
Could you please run the following command locally to build docs changes? This should allow our static checks to pass.
npm run docs:buildCommitting the changes should make all checks green.
There was a problem hiding this comment.
Thanks for the PR!
The document content you update will be automatically built from JSDoc. Therefore, the original JSDoc needs to be updated. In other words, it is a packages/date/src/index.js file.
After updating See php.net/date. in this file to See https://php.net/date., you need to run npm run docs:build.
|
Thanks for contributing, @karstengresch! It looks like the issue has been resolved via #69280. I'm going to close the PR. |
Either the link given is intended to work (it does by forwarding) - then it should be functional. Or not - then it should be replaced. Right?
What?
Why?
How?
Testing Instructions
Testing Instructions for Keyboard
Screenshots or screencast