Size Change: 0 B

Total Size: 1.51 MB

_{compressed-size-action}

Flaky tests detected in 48d60ee.
Some tests passed with failed attempts. The failures may not be related to this commit but are still reported for visibility. See the documentation for more information.

🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/5962582248
📝 Reported issues:

• [Flaky Test] should partially select with shift + click (@webkit) #53524 in /test/e2e/specs/editor/various/multi-block-selection.spec.js

Hard to tell if this is working but I'm not seeing the failure anymore. I'm tempted to just merge this.

Just to help with context this PR was in response to this test failing way too often:
[firefox] › editor/various/inserting-blocks.spec.js:34:2 › Inserting blocks (@firefox, @webkit) › inserts blocks by dragging and dropping from the global inserter

There was some speculation on why this started happening in #53768 (comment).

It looks like the change here helped but it'd be nice to actually fix that test.

cc @WunderBart in case you have an idea here. For the record, the current PR didn't solve the problem.

cc @WunderBart in case you have an idea here. For the record, the current PR didn't solve the problem.

Will take a look shortly.
/cc @kevin940726 @Mamaduka @t-hamano in case one of you folks is already looking into this.

I tried to debug this but was unsuccessful :(

This is the only related issue I could find regarding the error message logged by the test - microsoft/playwright#21210.

From the Artifacts capture, it looks like it fails before the first block is inserted. Wishful thinking, but I am trying to do a little testing with #54058 😅

From the Artifacts capture, it looks like it fails before the first block is inserted. Wishful thinking, but I am trying to do a little testing with #54058 😅

This might be due to a test design issue I've noticed, where we initialize a new post (createNewPost) in beforeEach hook and then mark some tests as fixme (aka skip). This pattern causes tests not to be truly skipped because the new post gets created and the timers are initialized. I don't know if this is at fault here, but it's worth checking IMO.

Testing a fix in #54065. The first run was successful, rerunning now to be sure.

edit

The second attempt passed without any hiccups as well. 🎉 It should be safe to merge at this point!