-
Notifications
You must be signed in to change notification settings - Fork 4.6k
Content Block: Change placeholder and e2e test to refer to Content block #53902
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Content Block: Change placeholder and e2e test to refer to Content block #53902
Conversation
Thanks for opening this PR @jordesign! The code change is generally looking good. One issue in this PR is that the included changes in Do you mind removing the change to Then, you'd commit and push the updated file. If you're finding that there's often changes to |
Thanks @andrewserong - I had been wondering why that kept showing up as changed 😂 I've reverted back to the old version of it now |
@jordesign thanks for updating! It looks like you might need to do a fresh Apologies, I didn't catch that you're working from a fork, so likely your trunk branch is behind the origin trunk. A couple of ways to update to the latest file:
|
Right you are - that should be resolved now @andrewserong |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the updates Jordan, this LGTM! ✨
I noticed one of the playwright e2e jobs failed, but the error message didn't look related to this PR, so I've just kicked it off again to see if that'll get it passing 🤞
Fantastic - looks like it worked this time around - so I'll merge that now. |
What?
Updates the placeholder text for the Content block (which was recently changed from the 'Post Content' block) so it no longer refers to itself as the Post Content block.
Why?
Recently the Post Content block was changed to just be the 'Content' block. This update brings the placeholder text up to date.
Addresses #53894
Testing Instructions
Screenshots or screencast