Skip to content

Conversation

jordesign
Copy link
Contributor

What?

Updates the placeholder text for the Content block (which was recently changed from the 'Post Content' block) so it no longer refers to itself as the Post Content block.

Why?

Recently the Post Content block was changed to just be the 'Content' block. This update brings the placeholder text up to date.

Addresses #53894

Testing Instructions

  1. Open or add a template in the site editor
  2. Add a 'Content' block
  3. Confirm that the placeholder content refers to the 'Content' block, not the 'Post Content' block

Screenshots or screencast

Screenshot 2023-08-24 at 12 51 54 pm

@jordesign jordesign added [Type] Enhancement A suggestion for improvement. [Block] Post Content Affects the Post Content Block labels Aug 24, 2023
@andrewserong
Copy link
Contributor

Thanks for opening this PR @jordesign! The code change is generally looking good. One issue in this PR is that the included changes in package-lock.json appear to be causing the Github Actions to fail.

Do you mind removing the change to package-lock.json? I think you should be able to do it locally by running git checkout trunk ./package-lock.json to restore the file in this branch to the state that is on trunk:

image

Then, you'd commit and push the updated file.

If you're finding that there's often changes to package-lock.json when creating branches, one approach to avoid it is to use npm ci when installing dependencies instead of npm installnpm ci uses the versions of dependencies from the package-lock.json, so your local environment will more closely match the environment used in Github actions.

@jordesign
Copy link
Contributor Author

Thanks @andrewserong - I had been wondering why that kept showing up as changed 😂

I've reverted back to the old version of it now

@andrewserong
Copy link
Contributor

andrewserong commented Aug 24, 2023

@jordesign thanks for updating! It looks like you might need to do a fresh pull of trunk, as the changes to package-lock.json appear to be from an older version (GB 16.1.0-rc.1).

Apologies, I didn't catch that you're working from a fork, so likely your trunk branch is behind the origin trunk. A couple of ways to update to the latest file:

  • The quick way for this branch, you can specify the remote at the same time as checking out the single file, so git checkout origin/trunk ./package-lock.json (origin/trunk instead of trunk) — if your remote pointing to wordpress/gutenberg is different to origin then use that word instead. You can check your current remotes by running git remote -v.
  • Or, check out your trunk branch and pull the latests changes before switching to your PR's branch and doing the previous git checkout trunk ./package-lock.json command above

@jordesign
Copy link
Contributor Author

Right you are - that should be resolved now @andrewserong

Copy link
Contributor

@andrewserong andrewserong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the updates Jordan, this LGTM! ✨

I noticed one of the playwright e2e jobs failed, but the error message didn't look related to this PR, so I've just kicked it off again to see if that'll get it passing 🤞

@jordesign
Copy link
Contributor Author

Fantastic - looks like it worked this time around - so I'll merge that now.

@jordesign jordesign merged commit 7d6ce36 into WordPress:trunk Aug 24, 2023
@jordesign jordesign deleted the try_post_content_placeholder_update branch August 24, 2023 06:05
@github-actions github-actions bot added this to the Gutenberg 16.6 milestone Aug 24, 2023
@bph bph added [Type] Bug An existing feature does not function as intended and removed [Type] Enhancement A suggestion for improvement. labels Aug 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Post Content Affects the Post Content Block [Type] Bug An existing feature does not function as intended
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants