Skip to content

with-focus-outside: Convert to TypeScript #53980

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Sep 11, 2023
Merged

with-focus-outside: Convert to TypeScript #53980

merged 9 commits into from
Sep 11, 2023

Conversation

margolisj
Copy link
Contributor

What?

Why?

How?

Testing Instructions

Testing Instructions for Keyboard

Screenshots or screencast

@margolisj margolisj requested a review from ajitbohra as a code owner August 28, 2023 06:57
@margolisj
Copy link
Contributor Author

@mirka @ciampo Anotha one for #35744. This one being only slightly more spicy that the previous small one.
Let me know if you'd like me to change anything. Cheers.

@mirka mirka added [Type] Code Quality Issues or PRs that relate to code quality [Package] Components /packages/components labels Aug 29, 2023
@mirka mirka requested review from mirka and ciampo August 29, 2023 14:06
@margolisj margolisj force-pushed the HigherOrder-with-focus-outside branch from bd66e07 to d7be667 Compare September 5, 2023 14:14
ciampo
ciampo reviewed Sep 5, 2023
View reviewed changes
@margolisj margolisj force-pushed the HigherOrder-with-focus-outside branch from e42de20 to 42a1322 Compare September 8, 2023 17:15
margolisj
margolisj commented Sep 8, 2023
View reviewed changes
@margolisj
Copy link
Contributor Author

Rebased from trunk and responded to comments.

@ciampo ciampo mentioned this pull request Sep 9, 2023
Closed
@ciampo ciampo enabled auto-merge (squash) September 11, 2023 08:16
@ciampo ciampo merged commit 65bf4f7 into WordPress:trunk Sep 11, 2023
@github-actions github-actions bot added this to the Gutenberg 16.7 milestone Sep 11, 2023
@margolisj margolisj deleted the HigherOrder-with-focus-outside branch September 12, 2023 18:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ciampo ciampo ciampo approved these changes

@ajitbohra ajitbohra Awaiting requested review from ajitbohra ajitbohra is a code owner

@mirka mirka Awaiting requested review from mirka

Assignees

@margolisj margolisj

Labels
[Package] Components /packages/components [Type] Code Quality Issues or PRs that relate to code quality
Projects
None yet
Milestone
Gutenberg 16.7
Development

Successfully merging this pull request may close these issues.
3 participants
@margolisj @ciampo @mirka