Post Editor: Fix browser console error when changing device preview mode #53969
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: +16 B (0%) Total Size: 1.51 MB
ℹ️ View Unchanged
|
andrewserong
approved these changes
Aug 29, 2023
There was a problem hiding this comment.
Thanks for fixing this up @t-hamano!
✅ Confirmed the error appears on trunk
✅ Confirmed the error no longer appears with this PR applied
✅ Additional marginLeft and marginRight rules appear to be safe due to the width: 100% rule. Tested with iframed and non-iframed editor, on Chrome, Safari, FF, and Edge on Mac
LGTM! ✨
|
Thanks for the review, @andrewserong! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
This PR fixes browser console errors when changing device preview mode in the Post Editor.
d3af6bd199de390b9b99763686a4d202.mp4
Why?
In motion, it does not seem to be allowed to animate the margin from
0toauto.How?
I have tried
margin: '0 auto',margin: 0px auto, etc., but could not get rid of the error. Finally, I was able to solve the problem by applying auto margin only to the left and right sides.Testing Instructions