Skip to content

Conversation

Mamaduka
Copy link
Member

What?

PR fixes cleanup in the SandBox component to correctly remove the event handler.

Testing Instructions

CI checks are green.

@Mamaduka Mamaduka added [Type] Bug An existing feature does not function as intended [Package] Components /packages/components labels Aug 18, 2023
@Mamaduka Mamaduka self-assigned this Aug 18, 2023
@Mamaduka Mamaduka requested a review from ajitbohra as a code owner August 18, 2023 06:17
@Mamaduka Mamaduka requested review from mirka and removed request for ajitbohra August 18, 2023 06:17
Copy link
Member

@mirka mirka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My bad, thanks for catching! 😱

@github-actions
Copy link

Flaky tests detected in ac547e9.
Some tests passed with failed attempts. The failures may not be related to this commit but are still reported for visibility. See the documentation for more information.

🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/5903576915
📝 Reported issues:

@Mamaduka Mamaduka merged commit 17bc4c2 into trunk Aug 18, 2023
@Mamaduka Mamaduka deleted the fix/sandbox-component-cleanup branch August 18, 2023 15:11
@github-actions github-actions bot added this to the Gutenberg 16.6 milestone Aug 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Package] Components /packages/components [Type] Bug An existing feature does not function as intended
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants