List View: Allow replacing template part when a block isn't selected #53757
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: +20 B (0%) Total Size: 1.51 MB
ℹ️ View Unchanged
|
andrewserong
approved these changes
Aug 17, 2023
There was a problem hiding this comment.
This is testing nicely for me 👍
✅ Replacement while a template part block is selected works as usual
✅ Replacement is now possible while a block is not selected
✅ The option to replace is not available if multiple blocks are selected
This also happens on the trunk; we should investigate this separately.
Agreed, looking into this separately sounds good. It looks like it takes a moment for the new option to render, so it mightn't be as simple as shifting focus to it immediately 🤔
Another option could be that when the block is replaced, to shift focus to the list view row instead and close the options menu — a bit like how it's done when a block is duplicated via the options menu? In any case, not a blocker for this one.
LGTM! ✨
|
Thanks, @andrewserong! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Fixes #50928.
PR allows replacing a template part from List View block options when the block itself isn't selected.
Why?
This makes the feature consistent with block options in the toolbar.
How?
I've replaced the block level
isSelectedsafeguard with a similar check inside theBlockSettingsMenuControlsrender callback.Props to @getdave for inspiration.
P.S. I noticed that the focus isn't returned to the "Options" dropdown after replacement. Probably due to that, the new component in the list view is replaced, unmounting the old one and mounting the new one.
This also happens on the
trunk; we should investigate this separately.Testing Instructions
footerorheaderarea template parts.Screenshots or screencast