Try: Change PR label enforcer automation not to work on draft PRs by default #53417
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The change makes sense to me, or at least how I use "Draft" vs. "Ready for Preview" PRs. On rare occasions when I push draft PRs, I don't fill out any details; I mostly want to see if CI checks catch anything. Once I think it's in good condition (they rarely are 😄), I'll add details and request reviews. |
|
All we need to merge this then is a favorable review 🙂 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Changes the GitHub workflow that enforces PRs have proper labels not to work on draft PRs by default—original conversation found in WordPress Slack.
Why?
Some folks have suggested removing it. I would like to hear more drawbacks of having this check for draft PRs.
Some benefits I see of doing the label checks even on draft PRs:
How?
Removes the triggers
openedandsynchronize, and addsready_for_reviewandreview_requested. With these changes, the check would still apply to draft PRs in some scenarios, primarily when adding or removing labels, but also when asking folks to review: in my opinion, if people are invited to check a PR, it should indeed have proper labels to help these people get the context of the PR.