Fix extraction of _nx translation function #5330
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aduth
reviewed
Mar 1, 2018
i18n/babel-plugin.js
Outdated
| @@ -58,7 +58,7 @@ const DEFAULT_FUNCTIONS = { | |||
| __: [ 'msgid' ], | |||
| _n: [ 'msgid', 'msgid_plural' ], | |||
| _x: [ 'msgid', 'msgctxt' ], | |||
| _nx: [ 'msgid', 'msgctxt', 'msgid_plural' ], | |||
| _nx: [ 'msgid', 'msgid_plural', '_', 'msgctxt' ], | |||
There was a problem hiding this comment.
Following the logic, I don't think we really need to assign anything for the number argument. Even null or undefined would suffice:
gutenberg/i18n/babel-plugin.js
Lines 213 to 214 in 3134e1a
gutenberg/i18n/babel-plugin.js
Lines 167 to 169 in 3134e1a
gutenberg/i18n/babel-plugin.js
Line 76 in 3134e1a
516ce0e to
f688999
Compare
f688999 to
ae6f68a
Compare
|
I change the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
While working on #5310 I found that the babel plugin was not correctly extracting the
_nxfunction. I have usednullas a placeholder for the number argument because that explicitly signals a not-used value.How Has This Been Tested?
Ran in combination with #5310. The PHP file corresponded to my test values of
_nx.Types of changes
Bug fix (non-breaking change which fixes an issue)
Checklist: