Skip to content

Video: Fixing styles that vertical alignment of the video #53131

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 30, 2023
Merged

Video: Fixing styles that vertical alignment of the video #53131

merged 1 commit into from
Jul 30, 2023

Conversation

lunaluna
Copy link
Contributor

Fix #52944

Add styles vertical-align: middle; to .wp-block-video video

@lunaluna lunaluna requested a review from ajitbohra as a code owner July 29, 2023 03:24
@github-actions
Copy link

👋 Thanks for your first Pull Request and for helping build the future of Gutenberg and WordPress, @lunaluna! In case you missed it, we'd love to have you join us in our Slack community, where we hold regularly weekly meetings open to anyone to coordinate with each other.

If you want to learn more about WordPress development in general, check out the Core Handbook full of helpful information.

@github-actions github-actions bot added the First-time Contributor Pull request opened by a first-time contributor to Gutenberg repository label Jul 29, 2023
@lunaluna
Copy link
Contributor Author

@t-hamano

@t-hamano t-hamano added [Type] Bug An existing feature does not function as intended [Block] Video Affects the Video Block labels Jul 30, 2023
@t-hamano t-hamano self-requested a review July 30, 2023 09:05
t-hamano
t-hamano approved these changes Jul 30, 2023
View reviewed changes
Copy link
Contributor

@t-hamano t-hamano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! This PR appears to correctly remove the unexpected space under the video tag.

Before

before

After

after

@t-hamano t-hamano merged commit aa3bd6b into WordPress:trunk Jul 30, 2023
@github-actions
Copy link

Congratulations on your first merged pull request, @lunaluna! We'd like to credit you for your contribution in the post announcing the next WordPress release, but we can't find a WordPress.org profile associated with your GitHub account. When you have a moment, visit the following URL and click "link your GitHub account" under "GitHub Username" to link your accounts:

https://profiles.wordpress.org/me/profile/edit/

And if you don't have a WordPress.org account, you can create one on this page:

https://login.wordpress.org/register

Kudos!

@github-actions github-actions bot added this to the Gutenberg 16.4 milestone Jul 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@t-hamano t-hamano t-hamano approved these changes

@ajitbohra ajitbohra Awaiting requested review from ajitbohra ajitbohra is a code owner

Assignees
No one assigned
Labels
[Block] Video Affects the Video Block First-time Contributor Pull request opened by a first-time contributor to Gutenberg repository [Type] Bug An existing feature does not function as intended
Projects
None yet
Milestone
Gutenberg 16.4
Development

Successfully merging this pull request may close these issues.

Video Block on bottom has unexplainable 8px gap (could also be padding or margin)
2 participants
@lunaluna @t-hamano