Remove extraneous "Detach" ToolbarButton for synced patterns #53121
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: -323 B (0%) Total Size: 1.44 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in be3ff5f. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/5707833424
|
|
I’ll have a look on Monday 🙌 |
|
Makes sense to me. Detaching is relatively uncommon so the action in the block options menu seems adequate. |
|
I think it makes sense to tuck away "destructive" actions in the "Options" dropdown. |
|
I can't comment much about the patterns feature, but as for reusable blocks, our team does use the detach feature quite a lot every single day. It was a big regression for us the fact that the function is now hidden under the three-dot menu. 😓 Do you guys have statistics' data from general WordPress usage that corroborates the fact that our usage of this feature is that uncommon? |
|
As of WordPress 6.5, there's now a big button to edit the original block as if that's what people usually most do (and the detach command is still hidden under the three-dotted menu). I don't understand… |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
An alternative to #52998, removing the ToolbarButton altogether — as the option is included in the block options popover already. I don't think it's necessary to have duplicate controls; especially as the "Ungroup" icon is confusing by itself; and the toolbar for synced patterns may be extended with additional controls (perhaps "Edit").
@Mamaduka do you mind helping/arranging help with the reusable-blocks test? They may need updated to leverage the "Detach patterns" control within the block options toolbar. 🙇♂️
Testing Instructions
Screenshots or screencast