Add common commands (breadcrumbs, live preview, pre-publish checklist) #53073
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I wanted to use similar logic for the Show/hide block breadcrumbs command (where the title could reflect the action action, not "Show/hide" or "Toggle", but I couldn't get it quite working. |
|
Size Change: +383 B (0%) Total Size: 1.44 MB
ℹ️ View Unchanged
|
Here you go - b79af6c :) |
Mamaduka
reviewed
Jul 27, 2023
|
Flaky tests detected in 457debf. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/5690086490
|
Mamaduka
approved these changes
Jul 28, 2023
This was referenced Oct 4, 2023
22 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Add three commands to the command palette:
Why?
We need these commands, but I'm also trying out a couple UX patterns (such as the "Show/hide" vs. "Toggle", and using snackbars more prominently.
Testing Instructions
Testing Instructions for Keyboard
Screenshots or screencast