Replace horizontal ellipsis icon with vertical ellipsis icon. #52731
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: -97 B (0%) Total Size: 1.43 MB
ℹ️ View Unchanged
|
|
Ping @WordPress/gutenberg-design for a kind feedback. Also regarding the following point:
|
|
There are use cases still where the horizontal ellipsis can be used, so I don't think it should be removed from the library. I have seen some mockups related to fonts, where horizontal ellipsis can better indicate the direction of what happens next, i.e. when a menu opens to the right. I agree we should have some documentation on best practices. We might even end up back to a point where we realize, no, in fact we don't use the horizontal one and can remove it. But for now I think we should keep it just as we have arrows and chevrons pointing in all directions, as a utility that's available. |
|
Agree that we shouldn't remove the icon, especially as it's a public library and third parties may be using it. |
aristath
approved these changes
Jul 28, 2023
|
Thanks everyone for your feedback. Merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #52408
What?
All the ellipsis icon buttons in the editor use the vertical ellipsis icon, except two.
Also, the ellipsis button in the Patterns list has a small target size of only 24 x 24 pixels, which seems to be there only for visual concerns.
Why?
It is best to always use the same icon. consistency and affordance considerations prevail on any otehr ad-hoc visual consideration.
Regarding the target size: Functionality come first than visuals and the target size should be the standard one for icon buttons 36 X 36 pixels.
How?
Note: with this change, the
moreHorizontalicon is now unused. As such,packages/icons/src/library/more-horizontal.jscould be completely removed. Please do let me know what to do in this regard.Testing Instructions
Testing Instructions for Keyboard
Screenshots or screencast