Page List: Fix parent block selection when converting to link #52193
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: -35 B (0%) Total Size: 1.42 MB
ℹ️ View Unchanged
|
draganescu
approved these changes
Jul 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Closes #50477
PR fixes the block selection loss when converting the Page List block to the links from the List View settings tab.
I also (by accident) fixed a bug when an incorrect block was selected if Page List was nested in a submenu.
Why?
The side-effect that opens the modal also re-selects the parent navigation block. The action was causing the
parentNavBlockClientIdfrom theuseConvertToNavigationLinkshook to beundefinedsince the Navigation block can't have itself as a parent.How?
For simplicity, use the parent client ID from
navigationBlockParentsand pass it to theuseConvertToNavigationLinks.Testing Instructions
Screenshots or screencast
Before
CleanShot.2023-06-30.at.22.53.53.mp4
After
CleanShot.2023-06-30.at.22.53.13.mp4