Skip to content

Move grid function kses patch into 6.3 compat folder. #52098

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 3, 2023
Merged

Move grid function kses patch into 6.3 compat folder. #52098

merged 2 commits into from
Jul 3, 2023

Conversation

tellthemachines
Copy link
Contributor

What?

Now that kses support for CSS grid functions is in core (WP 6.3), the Gutenberg patch for it can be moved into the 6.3 compat folder.

Testing Instructions

  1. Enable the Grid experiment in the plugin experiments page.
  2. Add a Grid block to a page and check that it displays correctly in the front end.
  3. Choose "grid" layout type in the Post Template block.
  4. Save and check that Post Template grid displays correctly in the front end.

Testing Instructions for Keyboard

Screenshots or screencast

@tellthemachines tellthemachines self-assigned this Jun 29, 2023
@tellthemachines tellthemachines requested a review from ramonjd June 29, 2023 03:52
@tellthemachines tellthemachines added Backport from WordPress Core Pull request that needs to be backported to a Gutenberg release from WordPress Core [Feature] Layout Layout block support, its UI controls, and style output. labels Jun 29, 2023
ramonjd
ramonjd approved these changes Jun 29, 2023
View reviewed changes
Copy link
Member

@ramonjd ramonjd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Site editor

Screenshot 2023-06-29 at 2 17 38 pm Screenshot 2023-06-29 at 2 17 45 pm

Post editor

Screenshot 2023-06-29 at 2 12 03 pm Screenshot 2023-06-29 at 2 16 07 pm

@github-actions
Copy link

github-actions bot commented Jun 29, 2023 •
edited
Loading

Flaky tests detected in d15783cead4a5e27ac5f464cb5db2daa94f3447a.
Some tests passed with failed attempts. The failures may not be related to this commit but are still reported for visibility. See the documentation for more information.

🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/5408300362
📝 Reported issues:

@tellthemachines tellthemachines merged commit 5023dd5 into trunk Jul 3, 2023
@tellthemachines tellthemachines deleted the update/kses-patch branch July 3, 2023 01:48
@github-actions github-actions bot added this to the Gutenberg 16.2 milestone Jul 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ramonjd ramonjd ramonjd approved these changes

@spacedmonkey spacedmonkey Awaiting requested review from spacedmonkey spacedmonkey is a code owner

Assignees

@tellthemachines tellthemachines

Labels
Backport from WordPress Core Pull request that needs to be backported to a Gutenberg release from WordPress Core [Feature] Layout Layout block support, its UI controls, and style output.
Projects
None yet
Milestone
Gutenberg 16.2
Development

Successfully merging this pull request may close these issues.
2 participants
@tellthemachines @ramonjd