Fix e2e test for block API / filtered blocks #51882
Merged
+5
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
For reference the PR that introduced the test. I requested a review from Greg because he's the author. |
stokesman
commented
Jun 26, 2023
There was a problem hiding this comment.
For reference here’s the filter source:
gutenberg/packages/e2e-tests/plugins/block-api/index.js
Lines 17 to 31 in fe28cc9
It doesn't filter block content but rather the block title. So that's why I thought the assertion should be for the filtered title.
|
Size Change: 0 B Total Size: 1.85 MB ℹ️ View Unchanged
|
1006955 to
b02c0bd
Compare
|
Flaky tests detected in b02c0bd. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/5470416292
|
b02c0bd to
c22e28a
Compare
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Sorry for the branch override, @stokesman! I found this PR while cleaning old draft branches and decided to finish it instead of closing it. |
Mamaduka
approved these changes
May 29, 2025
|
Thank you @Mamaduka! |
chriszarate
pushed a commit
to chriszarate/gutenberg
that referenced
this pull request
Jul 1, 2025
Co-authored-by: Mamaduka <mamaduka@git.wordpress.org> Co-authored-by: stokesman <presstoke@git.wordpress.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
An attempt to fix a test that may not be doing what it's supposed to be. Noticed during work on #51824.
Why?
It's worth a look because the test might not guard against regressions.
Currently the test asserts that the filtered block is inserted and has a certain text content. I suspect that’s wrong because the filter doesn't change the text content so there’s nothing testing the filter had an effect.
Conversely, if the original issue was that a block would fail to be inserted if it had a filter added after its block type was registered, then this test is fine and this PR can be closed. However, that didn't seem to be the case from my reading of it.
How?
Creates an assertion for the effect of the filter.
Testing Instructions