Make the Site Logo block placeholder state smaller #48218
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: +2 B (0%) Total Size: 1.33 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in 00a506d. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/4207691140
|
carolinan
approved these changes
Feb 21, 2023
|
My sense is that the upload button that appears when this block is selected looks very cramped. How about at least 80px or 96px? |
The whole 60px x 60px placeholder should probably be entirely the upload button when selected, instead of a hybrid. Though that should be a separate effort imo. |
jameskoster
approved these changes
Feb 24, 2023
There was a problem hiding this comment.
I commented on the issue that we might want a more flexible solution here in the long run, but the reduction in size generally seems fine.
t-hamano
approved these changes
Feb 25, 2023
There was a problem hiding this comment.
The whole 60px x 60px placeholder should probably be entirely the upload button when selected, instead of a hybrid. Though that should be a separate effort imo.
Understood, we can follow up on this point if necessary 👍 Performance test failures will be resolved by rebasing with the latest trunk.
ntsekouras
pushed a commit
that referenced
this pull request
Feb 27, 2023
* Change site logo placeholder to 80x80 * Use 60px instead
|
I just cherry-picked this PR to the wp/6.2 branch to get it included in the next release: 28616a3 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Closes #48217 by making the Site Logo block's placeholder state smaller — from 120px by 120px to 60px by 60px.
Why?
The original intent for
120pxwas to match the default image width that is applied when an image is used as the logo. But as a 1:1 ratio, 120px by 120px does not represent a common logo height, and it distorts the vertical spacing of header patterns (causing substantial vertical shift when an image is applied).Maintaining a 1:1 is important as it helps to differentiate the site logo block from other image placeholders.
The current method for getting around this is setting the width within the block's attributes, although then the applied image will only render at 60px wide.
How?
SCSS change.
Testing Instructions
Screenshots or screencast
Current:
Proposed: