chore: add lint:fix ESLint "fix" npm script
#4712
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
noisysocks
requested changes
Jan 28, 2018
There was a problem hiding this comment.
This works well and I think it's a really useful addition!
I think we ought to update testing-overview.md to mention that we have this command.
|
Good call @noisysocks, added in c524285 |
noisysocks
approved these changes
Jan 29, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add an npm script implementing ESLint's
--fixoptionHow Has This Been Tested?
npm run lintto confirm that ESLint reports the errornpm run lint:fixto fix the errornpm run lintagain to confirm that no ESLint error or warnings are reportedgit statusto confirm the modified file you tested above is not in a Git dirty stateScreenshots (jpeg or gifs if applicable):
Types of changes
Build tooling change only
Checklist: