Migrate Font Size Picker tests to Playwright #46591
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: 0 B Total Size: 1.32 MB ℹ️ View Unchanged
|
This comment was marked as outdated.
This comment was marked as outdated.
|
Do we need |
This comment was marked as outdated.
This comment was marked as outdated.
Mamaduka
commented
Dec 16, 2022
| return doSet( obj, 0 ); | ||
| } | ||
|
|
||
| window.wp.data.dispatch( 'core/block-editor' ).updateSettings( |
There was a problem hiding this comment.
This settings update is a bit unreliable. Based on Playwright's trace, default font sizes can be restored in the middle of the test.
I'm thinking of extracting it into a new plugin and enabling/disabling it for this group of tests.
There was a problem hiding this comment.
I rerun tests on CI 4 times, and they pass without an issue. Probably only my local setup was flaky.
I think this is ready for review. I can try using the new fonts plugin if tests keep failing in the future.
b8c4caa to
85b03c7
Compare
t-hamano
approved these changes
Dec 16, 2022
|
Thanks for testing, @t-hamano! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Part of #38851.
Migrates
font-size-picker.test.jsto Playwright.Why?
It had a few flaky tests, and one has been failing a lot lately.
Closes #45392
Closes #45580
Closes #45556
How?
See MIGRATION.md for migration steps.
Note: I've inlined most of the helpers the previous test used since those were 2-3 lines long.
Testing Instructions