Add placeholder to Page List block #45871
Conversation
When there are no pages, the Page List block was showing an unnecessary notice when it was a child of a Navigation block. In order to more closely match the rendered front end and reduce clutter, I instead added a placeholder so that users whose intent is to have no pages can see a better representation of their site.
|
|
|
👋 Thanks for your first Pull Request and for helping build the future of Gutenberg and WordPress, @artemiomorales! In case you missed it, we'd love to have you join us in our Slack community, where we hold regularly weekly meetings open to anyone to coordinate with each other. If you want to learn more about WordPress development in general, check out the Core Handbook full of helpful information. |
|
If you allow can i help? |
|
Hi, @artemiomorales It looks like there's still an ongoing discussion on the issue. I think we can close this as stale until there's a final decision. |
|
Warning: Type of PR label mismatch To merge this PR, it requires exactly 1 label indicating the type of PR. Other labels are optional and not being checked here.
Read more about Type labels in Gutenberg. Don't worry if you don't have the required permissions to add labels; the PR reviewer should be able to help with the task. |
What?
Addresses issue #44486 — if a site has no pages, this PR adds a placeholder to the Page List block whenever it is a child of a Navigation block.
Why?
This is to improve the user experience for folks whose main intent is to have no pages; it makes the content in the editor more closely match the published site and reduces clutter.
How?
It adds a placeholder and styling to the Page List block.
Testing Instructions
Screenshots or screencast
Additional Notes