Skip to content

Migrate sidebar permalink to playwright #42585

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Migrate sidebar permalink to playwright #42585

wants to merge 1 commit into from
+61 −52

Conversation

pavanpatil1
Copy link
Contributor

What?

Part of #38851.
Migrate sidebar-permalink.test.js to its Playwright version.

Why?

Part of #38851.

How?

See MIGRATION.md for migration steps.

Testing Instructions

Run npm run test-e2e:playwright test/e2e/specs/editor/various/sidebar-permalink.spec.js

@pavanpatil1
Copy link
Contributor Author

Hi @kevin940726,

I have migrated the sidebar-permalink test case to the playwright, all CI checks have passed except the End-to-End Tests Playwright / E2E Tests.
But it's failing on Publish Post utils which I haven’t worked upon nor touched the file while working on this PR. I have also tried on local and it's still the same.

image

Can you please check and help me in reviewing this PR?

@skorasaurus skorasaurus added the [Type] Automated Testing Testing infrastructure changes impacting the execution of end-to-end (E2E) and/or unit tests. label Aug 9, 2022
@Mamaduka
Copy link
Member

Mamaduka commented Oct 9, 2023

Hi, @pavanpatil1

Are you planning to continue working on this migration?

@Mamaduka Mamaduka mentioned this pull request Nov 17, 2023
Merged
@github-actions github-actions bot added the [Status] In Progress Tracking issues with work in progress label Nov 17, 2023
@Mamaduka Mamaduka removed the [Status] In Progress Tracking issues with work in progress label Nov 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ntwb ntwb Awaiting requested review from ntwb ntwb is a code owner

@nerrad nerrad Awaiting requested review from nerrad nerrad is a code owner

@ajitbohra ajitbohra Awaiting requested review from ajitbohra ajitbohra is a code owner

Assignees

@Mamaduka Mamaduka

Labels
[Type] Automated Testing Testing infrastructure changes impacting the execution of end-to-end (E2E) and/or unit tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pavanpatil1 @Mamaduka @skorasaurus