[TypeScript] Add default context types to Entity Records in core-data #41595
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmsnell
approved these changes
Jun 8, 2022
|
Added the Needs Dev Note label in case this needs a dev note (either individual or as part of a "misc" dev note) for WP 6.1 release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
All entity record types are parametrized by a generic Context parameter, e.g.:
Oftentimes, we need to refer to an entity using its default context type, which gets pretty entangled:
This PR adds default value to all the Context generic type parameters so that the above can be simplified to:
Why?
We want to have autocompletion and TypeScript support for core-data primitives, see #39025 for more context.
Testing Instructions
Confirm the CI checks are green – this PR doesn't contain any runtime changes to test.
@noisysocks @sirreal @dmsnell @sarayourfriend