Skip to content

Conversation

miminari
Copy link
Member

@miminari miminari commented May 3, 2022

What?

Migrate paragraph.test.js to its Playwright version.

Why?

See #38570 for its background and rationale.

How?

See MIGRATION.md for migration steps.

Testing Instructions

Run npm run test-e2e:playwright -- /test/e2e/specs/editor/blocks/paragraph.spec.js.

related #38851

@miminari miminari requested review from ntwb, nerrad and ajitbohra as code owners May 3, 2022 08:15
@miminari miminari added the [Type] Automated Testing Testing infrastructure changes impacting the execution of end-to-end (E2E) and/or unit tests. label May 3, 2022
@miminari miminari requested a review from kevin940726 May 3, 2022 08:16
@kevin940726
Copy link
Member

kevin940726 commented May 3, 2022

Hi, thanks for the PR! Note that the new test should be placed in the test/e2e/specs folder though :) (and the old test should be deleted)

@miminari
Copy link
Member Author

miminari commented May 3, 2022

Hi, thanks for the PR! Note that the new test should be placed in the test/e2e/specs folder though :) (and the old test should be deleted)

@kevin940726
Thank you for your reply.

I am seeing this for the first time, but the GitHub display is seemingly showing the same file as changed... However, I have deleted the file in question and placed it in the appropriate directory.

Plz see this file.
https://github.com/WordPress/gutenberg/blob/243723701023673cd2fe49f1ae849357feb3155f/test/e2e/specs/editor/blocks/paragraph.spec.js

@kevin940726
Copy link
Member

Oh my bad! I misread it in the GitHub UI. You did it right 👍.

Copy link
Member

@kevin940726 kevin940726 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 💯

Thanks for the PR! 🧡 I'll merge it after CI passes.

@kevin940726 kevin940726 merged commit 58a43c0 into WordPress:trunk May 3, 2022
@github-actions github-actions bot added this to the Gutenberg 13.2 milestone May 3, 2022
@miminari miminari deleted the migrate/plaaywright-paragraph branch May 3, 2022 10:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Type] Automated Testing Testing infrastructure changes impacting the execution of end-to-end (E2E) and/or unit tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants