Skip to content

Extensibility: Respect the 'enter_title_here' hook #4059

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 18, 2017
Merged

Extensibility: Respect the 'enter_title_here' hook #4059

merged 1 commit into from
Dec 18, 2017

Conversation

youknowriad
Copy link
Contributor

closes #4042

This PR adds the enter_title_here to the editor's settings object and overrides the default title placeholder using this value.

Testing instructions

  • Add a filter like this
function change_title_text( $title ){
     return "my custom text";
}
  
add_filter( 'enter_title_here', 'change_title_text' );
  • Open Gutenberg and notice the title's placeholder displaying "my custom text"

@youknowriad youknowriad added the [Feature] Extensibility The ability to extend blocks or the editing experience label Dec 18, 2017
@youknowriad youknowriad self-assigned this Dec 18, 2017
gziolo
gziolo reviewed Dec 18, 2017
View reviewed changes
editor/components/post-title/index.js
@@ -116,7 +117,7 @@ class PostTitle extends Component {
className="editor-post-title__input"
value={ title }
onChange={ this.onChange }
placeholder={ __( 'Add title' ) }
placeholder={ placeholder || __( 'Add title' ) }
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we still need to have a default value here? What if a plugin author picks to set an empty string as a placeholder?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know :). My thinking was to make this optional in case we instantiate this editor client-side in the future.

gziolo
gziolo approved these changes Dec 18, 2017
View reviewed changes
Copy link
Member

@gziolo gziolo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had only one small concern. It might be a non-issue. Otherwise code-wise everything looks good 👍

@youknowriad youknowriad merged commit 6a287a4 into master Dec 18, 2017
@youknowriad youknowriad deleted the apply/title-placeholder-filter branch December 18, 2017 15:58
@afercia afercia mentioned this pull request Feb 7, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gziolo gziolo gziolo approved these changes

Assignees

@youknowriad youknowriad

Labels
[Feature] Extensibility The ability to extend blocks or the editing experience
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Respect the 'enter_title_here' hook
2 participants
@youknowriad @gziolo