Skip to content

Impossible to undo Convert to Blocks when post_content contains a core oEmbed link #7323

@chrisvanpatten

Description

@chrisvanpatten

Describe the bug
Clicking "Convert to Blocks" successfully converts classic editor content to blocks, and appears to add to the undo history, but clicking "undo" has no result.

In my testing this is caused by oEmbed lines in post_content pointing to WP posts.

To Reproduce
Steps to reproduce the behavior:

  1. Create a post in the Classic Editor with a WordPress oEmbed link, e.g.…
My paragraph

https://www.chrisvanpatten.com/notes-from-wordcamp-halifax-2018

My other paragraph
  1. Open the post in Gutenberg
  2. Open the Classic Editor block's settings menu and select "Convert to Blocks"
  3. Note that the Undo button is enabled
  4. Try to click undo
  5. See nothing happen

Expected behavior
Either this process should be "undoable" or the undo button shouldn't change its state.

Screenshots
kapture 2018-06-15 at 16 26 29

Desktop (please complete the following information):

  • OS: macOS High Sierra 10.13.5
  • Browser: Safari 11.1.1
  • Gutenberg Version: 3.0.1

Metadata

Metadata

Assignees

No one assigned

    Labels

    [Feature] Block TransformsBlock transforms from one block to another[Priority] HighUsed to indicate top priority items that need quick attention

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions