-
Notifications
You must be signed in to change notification settings - Fork 4.5k
Open
Labels
[Package] Interactivity Router/packages/interactivity-router/packages/interactivity-router[Status] In ProgressTracking issues with work in progressTracking issues with work in progress[Type] EnhancementA suggestion for improvement.A suggestion for improvement.
Description
What problem does this address?
The Interactivity Router store contains details that are internal and are not part of the public API, like for example:
gutenberg/packages/interactivity-router/src/index.ts
Lines 273 to 276 in 491d0ac
navigation: { | |
hasStarted: boolean; | |
hasFinished: boolean; | |
}; |
What is your proposed solution?
Those internal properties should be taken out of the public store and moved to a private store instead, so they are not used as public APIs. We can keep them with some deprecation warnings during one or two major versions of WordPress, though.
The namespace of this store could be core/router/private
and it should be a locked store.
yashjawale
Metadata
Metadata
Assignees
Labels
[Package] Interactivity Router/packages/interactivity-router/packages/interactivity-router[Status] In ProgressTracking issues with work in progressTracking issues with work in progress[Type] EnhancementA suggestion for improvement.A suggestion for improvement.