Skip to content

Block option 'edit visually' and 'edit HTML' still available when block is in warning state #7743

@johngodley

Description

@johngodley

If you put a block into a warning state (edit HTML and remove some tags) then the block option 'Edit visually' and 'Edit as HTML' are still available and seem to toggle state, but have no apparent effect on the block.

For simplicity they should probably be removed while the block is showing a warning.

To Reproduce
Steps to reproduce the behavior:

  1. Type some text in a block
  2. Edit the block as HTML
  3. Remove the trailing </p> tag
  4. Click outside the block to show a warning
  5. Click the blocks options to see that 'Edit visually' is still available and toggles to 'Edit as HTML' if selected, but with no change in the block

Expected behavior
The 'Edit visually' and 'Edit as HTML' to be disabled or not present in the menu. I think it will cause confusion when they don't do anything.

Screenshots
Block in warning state shows edit option:

block

Clicking this toggles the option but has no outward effect:

blok

Metadata

Metadata

Assignees

Labels

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions