-
Notifications
You must be signed in to change notification settings - Fork 4.5k
Closed
Labels
[Feature] Synced PatternsRelated to synced patterns (formerly reusable blocks)Related to synced patterns (formerly reusable blocks)[Status] In ProgressTracking issues with work in progressTracking issues with work in progress[Type] BugAn existing feature does not function as intendedAn existing feature does not function as intended
Description
Description
When editing the original pattern and the block has overrides active, some attributes like 'aspect ratio' don't work.
This is a side effect of #62471, which disabled regular attribute updates for any block with a __default
pattern override binding. The intention of that PR was to only affect pattern instances to stop situations where edits could be applied to 'locked' parts of blocks. However, it also affects the block when editing the original pattern.
I think it may be worth reverting that PR, even though reverting will cause two new issues:
- The original issue that Block Bindings / Pattern Overrides: Prevent normal attribute updates when a __default binding exists #62471 tried to solve, captions could incorrectly be set via the media library for overridden blocks in pattern instances, but the value doesn't persist when saving
- For editing the original pattern, Pattern overrides: disallow override for image with caption/href #62747 tried to solve an issue where users can display a caption for an image block with overrides, even though captions aren't supported. Block Bindings / Pattern Overrides: Prevent normal attribute updates when a __default binding exists #62471 disallows setting the caption, but also disallows setting any other unbound attributes too.
Step-by-step reproduction instructions
- Create a pattern
- Add an image block
- Enable bindings for the image block
- Upload an image to the block
- Try adjusting Aspect Ratio, observe it doesn't work.
Screenshots, screen recording, code snippet
No response
Environment info
No response
Please confirm that you have searched existing issues in the repo.
Yes
Please confirm that you have tested with all plugins deactivated except Gutenberg.
Yes
Metadata
Metadata
Assignees
Labels
[Feature] Synced PatternsRelated to synced patterns (formerly reusable blocks)Related to synced patterns (formerly reusable blocks)[Status] In ProgressTracking issues with work in progressTracking issues with work in progress[Type] BugAn existing feature does not function as intendedAn existing feature does not function as intended