-
Notifications
You must be signed in to change notification settings - Fork 4.5k
Closed
Labels
Needs Accessibility FeedbackNeed input from accessibilityNeed input from accessibilityNeeds Design FeedbackNeeds general design feedback.Needs general design feedback.[Package] Editor/packages/editor/packages/editor[Status] In ProgressTracking issues with work in progressTracking issues with work in progress[Type] BugAn existing feature does not function as intendedAn existing feature does not function as intended
Description
Description
In #63669, some improvements have been made to the post URL UI. As part of this, the ExternalLink
component is now applied to the post URL instead of the Button
component when on the front page.
The ExternalLink
component has very little styling, so its styling is affected by the link styling provided by WP-Admin. This results in inconsistencies with other panels.
Here's what I feel is the problem.
- The color doesn't match with other panels if the admin color scheme is changed:
- Even though the color scheme is the default, the colors are slightly different. Additionally, there is no focus animation, and the focus outline is styled differently:
- The
a
element hasrel="external"
. Theexternal
value is used to the referenced document is not part of the current site, so I don't think it's appropriate.
Step-by-step reproduction instructions
- Set any page as the front page.
- Open the page.
- Check the post sidebar.
Screenshots, screen recording, code snippet
No response
Environment info
No response
Please confirm that you have searched existing issues in the repo.
- Yes
Please confirm that you have tested with all plugins deactivated except Gutenberg.
- Yes
Please confirm which theme type you used for testing.
- Block
- Classic
- Hybrid (e.g. classic with theme.json)
- Not sure
coder-rancho
Metadata
Metadata
Assignees
Labels
Needs Accessibility FeedbackNeed input from accessibilityNeed input from accessibilityNeeds Design FeedbackNeeds general design feedback.Needs general design feedback.[Package] Editor/packages/editor/packages/editor[Status] In ProgressTracking issues with work in progressTracking issues with work in progress[Type] BugAn existing feature does not function as intendedAn existing feature does not function as intended
Type
Projects
Status
✅ Done