Skip to content

Password protected input fields are inconsistent #69439

@afercia

Description

@afercia

Description

Discovered while working on #60275

The password protected fields in the Post Summary panel and in the pre-publish panel are inconsistent.

  • THe first one uses a TextControl component while the second one uses n <input> with ad-hoc handling and styling.
  • The second one uses unnecessary styling and mixins that would be built-in if using a TextControl.
  • The second one has a non-standard height: all input fields should now have an height of 40 pixels.
  • Inconsistent labeling and description

Screenshot:

Image

Step-by-step reproduction instructions

  • edit a draft post.
  • open the Settings panel and open the visibility popover.
  • Select 'Password protected' and observe the input field.
  • Compare with the passord field in the pre-publish panel.

Screenshots, screen recording, code snippet

No response

Environment info

No response

Please confirm that you have searched existing issues in the repo.

  • Yes

Please confirm that you have tested with all plugins deactivated except Gutenberg.

  • Yes

Please confirm which theme type you used for testing.

  • Block
  • Classic
  • Hybrid (e.g. classic with theme.json)
  • Not sure

Metadata

Metadata

Assignees

Labels

[Focus] Accessibility (a11y)Changes that impact accessibility and need corresponding review (e.g. markup changes).[Package] Editor/packages/editor[Status] In ProgressTracking issues with work in progress[Type] BugAn existing feature does not function as intended

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions