-
Notifications
You must be signed in to change notification settings - Fork 4.5k
Closed
Labels
Global StylesAnything related to the broader Global Styles efforts, including Styles Engine and theme.jsonAnything related to the broader Global Styles efforts, including Styles Engine and theme.jsonNeeds Design FeedbackNeeds general design feedback.Needs general design feedback.[Focus] Accessibility (a11y)Changes that impact accessibility and need corresponding review (e.g. markup changes).Changes that impact accessibility and need corresponding review (e.g. markup changes).[Package] Edit Site/packages/edit-site/packages/edit-site[Status] In ProgressTracking issues with work in progressTracking issues with work in progress[Type] BugAn existing feature does not function as intendedAn existing feature does not function as intended
Description
Description
Similar to #66525
In the Site editor 'site view', the navigation panel > Styles, shows a control to go to the Revisions:
The visible text of this button is, for example:
Last modified 3 days ago
the actual accessible nae provided by the button aria-label is:
aria-label="Revisions"
FOr the same reasons explained in #66525, this kinf od mismatch must be avoided.
Also, interactive controls aren't the right place to provide information about states or values. They have to provide information about the button action.
Step-by-step reproduction instructions
- Make sure you have some global styles revisions. If necessary, go to the Site Editor > Styles, make any change and save.
- Go to the main navigation panel in the Site editor 'site view'.
- Go to the Styles sub-panel.
- Inspect the source of the button at the bottom of the panel.
- Observe the visible text is about the last modified date, while the accessible name is 'Revisions'.
Screenshots, screen recording, code snippet
No response
Environment info
No response
Please confirm that you have searched existing issues in the repo.
- Yes
Please confirm that you have tested with all plugins deactivated except Gutenberg.
- Yes
Please confirm which theme type you used for testing.
- Block
- Classic
- Hybrid (e.g. classic with theme.json)
- Not sure
Metadata
Metadata
Labels
Global StylesAnything related to the broader Global Styles efforts, including Styles Engine and theme.jsonAnything related to the broader Global Styles efforts, including Styles Engine and theme.jsonNeeds Design FeedbackNeeds general design feedback.Needs general design feedback.[Focus] Accessibility (a11y)Changes that impact accessibility and need corresponding review (e.g. markup changes).Changes that impact accessibility and need corresponding review (e.g. markup changes).[Package] Edit Site/packages/edit-site/packages/edit-site[Status] In ProgressTracking issues with work in progressTracking issues with work in progress[Type] BugAn existing feature does not function as intendedAn existing feature does not function as intended