-
Notifications
You must be signed in to change notification settings - Fork 4.5k
Labels
[Feature] Synced PatternsRelated to synced patterns (formerly reusable blocks)Related to synced patterns (formerly reusable blocks)[Feature] Write mode[Status] In ProgressTracking issues with work in progressTracking issues with work in progress[Type] BugAn existing feature does not function as intendedAn existing feature does not function as intended
Description
Description
(This is the issue that the PR #65408 was intended to solve, but it was reverted due to a performance issue)
Usually synced pattern content is only editable when a block has pattern overrides enabled.
In Write Mode though, all pattern content is editable regardless of overrides.
The bug happens because the getBlockEditingMode
changes the editing mode of pattern inner blocks when in Write Mode, whereas usually the pattern block sets the editing of its inner blocks mode itself.
Step-by-step reproduction instructions
- Insert a synced pattern with a mixture of overridden an non-overridden content blocks
- Try editing various blocks
- Observe that non-overridden blocks can't be edited
- Enable Write Mode
- Now observe that non-overriden blocks can be edited
Screenshots, screen recording, code snippet
No response
Environment info
No response
Please confirm that you have searched existing issues in the repo.
- Yes
Please confirm that you have tested with all plugins deactivated except Gutenberg.
- Yes
Please confirm which theme type you used for testing.
- Block
- Classic
- Hybrid (e.g. classic with theme.json)
- Not sure
andrewserong
Metadata
Metadata
Assignees
Labels
[Feature] Synced PatternsRelated to synced patterns (formerly reusable blocks)Related to synced patterns (formerly reusable blocks)[Feature] Write mode[Status] In ProgressTracking issues with work in progressTracking issues with work in progress[Type] BugAn existing feature does not function as intendedAn existing feature does not function as intended