-
Notifications
You must be signed in to change notification settings - Fork 4.6k
Open
Labels
[Package] Components/packages/components/packages/components[Type] Tracking IssueTactical breakdown of efforts across the codebase and/or tied to Overview issues.Tactical breakdown of efforts across the codebase and/or tied to Overview issues.
Description
Part of #46741
In our transition process to the new 40px default sizes, we are now ready to officially start the deprecation period by logging console warnings.
List of components
- BorderBoxControl BorderBoxControl: Deprecate 36px default size #65752
- BorderControl BorderControl: Deprecate 36px default size #65755
- BoxControl BoxControl: Deprecate 36px default size #66704
- Button Button: Deprecate 36px default size #68328
- ComboboxControl ComboboxControl : Deprecate 36px default size #66900
- CustomSelectControl CustomSelectControl: Deprecate 36px default size #67441
- DimensionControl DimensionControl: Deprecate 36px default size #66705
- FontSizePicker FontSizePicker : Deprecate 36px default size #66920
- FormFileUpload FormFileUpload: Deprecate 36px default size #67438
- FormTokenField FormTokenField: Deprecate 36px default size #67454
- InputControl InputControl : Deprecate 36px default size #66897
- NumberControl NumberControl: Deprecate 36px default size #66730
- Radio Radio: Deprecate 36px default size #66572
- RangeControl Feat: Adds the deprecation warning for 36px default size in range control. #66721
- SelectControl SelectControl : Deprecate 36px default size #66898
- TextControl TextControl: Deprecate 36px default size #66745
- ToggleGroupControl ToggleGroupControl : Deprecate 36px default size #66747
- TreeSelect TreeSelect: Deprecate 36px default size #67855
- UnitControl UnitControl : Deprecate 36px default size #66791
Block Editor
- FontAppearanceControl (CustomSelectControl) FontAppearanceControl: Deprecate 36px default size #67854
- FontFamilyControl (CustomSelectControl) FontFamilyControl: Deprecate 36px default size #67853
- LetterSpacingControl (UnitControl) LetteringSpacingControl: Deprecate 36px default size #67429
- LineHeightControl (NumberControl) LineHeightControl: Deprecate 36px default size #67850
Procedure
- [ ] Log deprecation warning
- [ ] Update unit tests
- [ ] Update Storybook (including all stories where the component is used)
- [ ] Update code snippets (Storybook, JSDoc, README)
- [ ] Changelog
- [ ] Add Dev Note tag
If used inside another wp-components component and the parent component is dictating the child component's size dynamically, the parent component is responsible for logging the deprecation warning. To suppress the redundant warning from the child component, add the __shouldNotWarnDeprecated36pxSize
prop as shown here for the ToggleGroupControl used inside FontSizePicker.
Success criteria
- [ ] Unit tests must all be passing
- [ ] If used in a Storybook story for another component, it must have the prop so it isn't logging console warnings
Metadata
Metadata
Assignees
Labels
[Package] Components/packages/components/packages/components[Type] Tracking IssueTactical breakdown of efforts across the codebase and/or tied to Overview issues.Tactical breakdown of efforts across the codebase and/or tied to Overview issues.