-
Notifications
You must be signed in to change notification settings - Fork 4.5k
Closed
Labels
[Package] Commands/packages/commands/packages/commands[Status] In ProgressTracking issues with work in progressTracking issues with work in progress[Type] BugAn existing feature does not function as intendedAn existing feature does not function as intended
Description
Description
I found that in both the post editor and site editor, running the following two commands did not launch the dialog:
Editor Preferences
Keyboard shortcuts
Both commands launch a modal dialog. This is very strange, but I found that it happens when StrictMode
is enabled.
Namely, the following parts. When I turn off StrictMode
, these two commands work again.
gutenberg/packages/edit-post/src/index.js
Lines 146 to 155 in 41d5ff2
root.render( | |
<StrictMode> | |
<Layout | |
settings={ settings } | |
postId={ postId } | |
postType={ postType } | |
initialEdits={ initialEdits } | |
/> | |
</StrictMode> | |
); |
gutenberg/packages/edit-site/src/index.js
Lines 101 to 105 in 41d5ff2
root.render( | |
<StrictMode> | |
<App /> | |
</StrictMode> | |
); |
Step-by-step reproduction instructions
- Launch the command palette.
- Run "Editor Preferences" or "Keyboard shortcuts"
Screenshots, screen recording, code snippet
eccfc1659f774e00adae86d1027dbe80.mp4
Environment info
No response
Please confirm that you have searched existing issues in the repo.
- Yes
Please confirm that you have tested with all plugins deactivated except Gutenberg.
- Yes
Metadata
Metadata
Assignees
Labels
[Package] Commands/packages/commands/packages/commands[Status] In ProgressTracking issues with work in progressTracking issues with work in progress[Type] BugAn existing feature does not function as intendedAn existing feature does not function as intended