Skip to content

Site Editor: Incorrect headings hierarch in the 'Manage all' screens #52254

@afercia

Description

@afercia

Description

Note: In the following screenshots, I'm using the HeadingsMap browser extension (available for Chrome and Firefox) to visually illustrate the headings in the page.

In 'Manage all templates', 'Manage all template parts', and possibly other 'manage all' screens, the headings hierarchy is incorrect and skips a few levels. A correct headings hierarchy is of fundamental importance for screen rearer users to efficiently navigate the content.

Edit: Please note there are also two H1 headings, which is incorrect.

I seem to recall the hierarchy was already fixed in a PR a while ago so I'm going to mark this issue as a regression.

On a side note: it would be great to re-focus all designers and developers attention to always check for a correct headings hierarchy. It's such a simple thing to implement but in the history of this project there have been several cases where new features have been shipped with a broken headings structure. @mtias I'd greatly appreciate any suggestions on the best way to train developers on this and make sure everybody is always focused on using headings correctly 🙏
See also #52253

This is basic semantics / accessibility / HTML. It would be great to just not use heading levels randomly.

ScreenshotL All templates:

Screenshot 2023-07-03 at 16 36 55

ScreenshotL All template parts:

Screenshot 2023-07-03 at 15 43 39

Step-by-step reproduction instructions

  • Use the HeadingsMap browser extension.
  • Go to the Site editor > Design > Templates > Manage all templates.
  • Observe the headings hierarchy is incorrect.
  • Go to the Site editor > Design > Patterns > Manage all template parts.
  • Observe the headings hierarchy is incorrect.

Screenshots, screen recording, code snippet

No response

Environment info

No response

Please confirm that you have searched existing issues in the repo.

Yes

Please confirm that you have tested with all plugins deactivated except Gutenberg.

Yes

Metadata

Metadata

Assignees

Labels

[Focus] Accessibility (a11y)Changes that impact accessibility and need corresponding review (e.g. markup changes).[Package] Edit Site/packages/edit-site[Type] BugAn existing feature does not function as intended[Type] RegressionRelated to a regression in the latest release

Type

No type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions