-
Notifications
You must be signed in to change notification settings - Fork 4.5k
Open
Labels
Global StylesAnything related to the broader Global Styles efforts, including Styles Engine and theme.jsonAnything related to the broader Global Styles efforts, including Styles Engine and theme.jsonNeeds DesignNeeds design efforts.Needs design efforts.[Type] EnhancementA suggestion for improvement.A suggestion for improvement.
Description
This issue flags some open questions raised in the following discussion:
cc @jameskoster
Identical styles message
It's possible that revisions match styles currently loaded in the editor,, e.g., if folks are using theme style variations or resetting and saving a lot.
When a revision's styles matches those in the editor, no "Apply" button is shown and the following message is displayed "These styles are already applied to your site."
Possible alternatives:
- shorter copy
- show the Apply button as per normal (even though it won't have any visual effect)
- semiotic/iconography?
Apply button behaviour
Currently, a style revision's "Apply" button restores that revision into the editor, and closes the styles revisions panel.
2024-02-01.10.24.15.mp4
The functionality to restore a revision is required, however the UX is open to review.
Alternatives:
- Show a confirmation modal (Do you wish to restore this revision?) before closing style revisions panel
- ?
Related
Metadata
Metadata
Assignees
Labels
Global StylesAnything related to the broader Global Styles efforts, including Styles Engine and theme.jsonAnything related to the broader Global Styles efforts, including Styles Engine and theme.jsonNeeds DesignNeeds design efforts.Needs design efforts.[Type] EnhancementA suggestion for improvement.A suggestion for improvement.