-
Notifications
You must be signed in to change notification settings - Fork 4.6k
Open
Labels
[Feature] Design ToolsTools that impact the appearance of blocks both to expand the number of tools and improve the experiTools that impact the appearance of blocks both to expand the number of tools and improve the experi[Type] EnhancementA suggestion for improvement.A suggestion for improvement.[Type] Tracking IssueTactical breakdown of efforts across the codebase and/or tied to Overview issues.Tactical breakdown of efforts across the codebase and/or tied to Overview issues.
Description
This is a small issue to track follow-up tasks associated with the aspect ratio block support that landed in #56897.
Short-term To-do
- Backport PHP code for the block support (Core PR: Backport aspect ratio block support wordpress-develop#5963)
- When updating aspect ratio in the Cover block, see if we can reset / clear the value for the Cover block's ad hoc minimum height control (so that it's clear to a user that the aspect ratio overrides the minimum height) — PR: Cover block: clear the min height field when aspect ratio is set #59191
- The aspect ratio dropdown displays Original as the selected item both when there is no aspect ratio set on the block and when the aspect ratio is explicitly set to
auto
. The default / unset state should be clearer. In terms of labelling, one idea would be to use the wordAuto
in all cases as suggested in this comment: Dimensions: Add Aspect Ratio block support #56897 (comment) - Cover block not working when changing the aspect ratio #60224
- Aspect ratio support breaks child theme CSS when unnecessary #60922
Longer term (for discussion and possibly to open separate issues)
- See which other blocks can use the block support rather than an ad hoc aspect ratio control — this way the controls are more consistent between blocks, and we can opt other blocks in to using aspect ratio in global styles. For example, what would be involved in converting the Featured Image block to use the block support?
- Which panel does aspect ratio best belong in? It would ultimately be good for it to be in a consistent place across all blocks.
- Group Block: Add Aspect Ratio Control #61326
- Cover block not working when changing the aspect ratio #60224
Tracked elsewhere
noisysocks, jasmussen and annezazu
Metadata
Metadata
Assignees
Labels
[Feature] Design ToolsTools that impact the appearance of blocks both to expand the number of tools and improve the experiTools that impact the appearance of blocks both to expand the number of tools and improve the experi[Type] EnhancementA suggestion for improvement.A suggestion for improvement.[Type] Tracking IssueTactical breakdown of efforts across the codebase and/or tied to Overview issues.Tactical breakdown of efforts across the codebase and/or tied to Overview issues.