-
Notifications
You must be signed in to change notification settings - Fork 4.5k
Description
Description
In the Edit Widgets page, the Settings panel toggle button shows a wrong icon when 'Show button text labels' is on.
It appears the Edit Widgets page is a bit behind and maybe a little overlooked.
To start with, it should fullly support 'Show button text labels', like the two other editors.
Anyways, when 'Show button text labels' is enabled in the post editor, the widgets editor shows a wrong icon instead of text.
See:
icon={ showIconLabels ? check : icon }
I'm not sure why the Complementary area toggle is supposed to show the 'check' icon when showIconLabels
is true. There's no apparent reason for that, unless I'm missing something. Cc @tellthemachines
It seems to be there since #24304
I'm not even shure the other editors use the ComplementaryArea
and ComplementaryAreaToggle
this way.
Step-by-step reproduction instructions
- Set Twenty Twenty-One as active theme.
- Go to Appearance > Widgets
- Observe the button to toggle the Settings panel shows the correct icon
drawerRight
. - Hover or focus the button and observe it shows a tooltip with text 'Settings'.
- Screenshot:
- Go to the post editor, and enable Options > Preferences > Accessibility > Show button text labels.
- Go to Appearance > Widgets
- Observe the button to toggle the Settings panel now shows a wrong 'check' icon.
- Hover or focus the button and observe there is no tooltip.
- Screenshot:
Screenshots, screen recording, code snippet
No response
Environment info
No response
Please confirm that you have searched existing issues in the repo.
Yes
Please confirm that you have tested with all plugins deactivated except Gutenberg.
Yes