-
Notifications
You must be signed in to change notification settings - Fork 4.6k
Open
Labels
Backwards CompatibilityIssues or PRs that impact backwards compatabilityIssues or PRs that impact backwards compatabilityInternationalization (i18n)Issues or PRs related to internationalization effortsIssues or PRs related to internationalization efforts[Feature] TypographyFont and typography-related issues and PRsFont and typography-related issues and PRs[Priority] LowUsed to indicate that the issue at hand isn't a top priority to address and can be handled laterUsed to indicate that the issue at hand isn't a top priority to address and can be handled later[Type] BugAn existing feature does not function as intendedAn existing feature does not function as intended
Description
Description
In Typography fluid fonts generator float
values are directly casted to string when generating CSS variables. This respects server locale and in some languages (e.g. Polish) it will cause floating point numbers to be comma separated (see picture).
Ref: https://stackoverflow.com/questions/17587581/php-locale-dependent-float-to-string-cast
Step-by-step reproduction instructions
- Set PHP locale to Polish
Screenshots, screen recording, code snippet
Environment info
No response
Please confirm that you have searched existing issues in the repo.
Yes
Please confirm that you have tested with all plugins deactivated except Gutenberg.
Yes
Metadata
Metadata
Assignees
Labels
Backwards CompatibilityIssues or PRs that impact backwards compatabilityIssues or PRs that impact backwards compatabilityInternationalization (i18n)Issues or PRs related to internationalization effortsIssues or PRs related to internationalization efforts[Feature] TypographyFont and typography-related issues and PRsFont and typography-related issues and PRs[Priority] LowUsed to indicate that the issue at hand isn't a top priority to address and can be handled laterUsed to indicate that the issue at hand isn't a top priority to address and can be handled later[Type] BugAn existing feature does not function as intendedAn existing feature does not function as intended