-
Notifications
You must be signed in to change notification settings - Fork 4.6k
Open
Labels
Global StylesAnything related to the broader Global Styles efforts, including Styles Engine and theme.jsonAnything related to the broader Global Styles efforts, including Styles Engine and theme.json[Block] SeparatorAffects the Separator BlockAffects the Separator Block[Feature] Style Book[Type] BugAn existing feature does not function as intendedAn existing feature does not function as intended
Description
Description
Where a theme has defined a border color for the core/separator
block, changing the colors in the Separator Block global style settings does not appear to update the block.
Themes:
I think this is because if a theme defines a value for styles.blocks.core/separator.border.color
, updating the global styles for the block will only change the background color.
It appears to be a bug with updateConfigWithSeparator() introduced in #44943
In the style book, changing the margins won't take effect for the separator block because the style book has rules that overrides them:
Step-by-step reproduction instructions
- In TT4 or TT5, open the Site editor and insert a Seperator block
- Change background color
- See that the block preview does not update correctly
- Open the style book and view the separator block
- Change the margins for the separator block in global styles
- The margin styles are overridden by the style book's CSS
Screenshots, screen recording, code snippet
Environment info
- WP: 6.5-alpha-56966-src
- Gutenberg: 17.3.0
Please confirm that you have searched existing issues in the repo.
Yes
Please confirm that you have tested with all plugins deactivated except Gutenberg.
Yes
Metadata
Metadata
Assignees
Labels
Global StylesAnything related to the broader Global Styles efforts, including Styles Engine and theme.jsonAnything related to the broader Global Styles efforts, including Styles Engine and theme.json[Block] SeparatorAffects the Separator BlockAffects the Separator Block[Feature] Style Book[Type] BugAn existing feature does not function as intendedAn existing feature does not function as intended