Skip to content

Slotfill no longer contextual? #56519

@albanyacademy

Description

@albanyacademy

Description

Not sure if I'm saying this right, but in 6.3.2 this custom taxonomy component for a custom block looked like this:
image

and in 6.4 it now looks like this:
image

(I confirmed this by changing nothing in our plugin's code, and only rolled back / forwards the wordpress version.)

This is being looped inside a Repeater field we've made, and the SlotFill implementation is standard as per the docs.

Inside our Taxonomy Settings Panel component:

// ... other stuff
<Fill name={ 'repeaterControls' }>
{ checked && (
	<Button
		isSmall={ true }
		text={ 'Settings' }
		variant={ open ? 'primary' : 'secondary' }
		onClick={ () => toggleOpen( ! open ) }
	/>
) }
</Fill>

Block Edit.js:

<RepeaterFieldV2
  fields={ taxonomies }
  >
  <TaxonomySettingsPanel
	  availableTaxes={ availableTaxes }
  />
</RepeaterFieldV2>

Inside Repeater.js:

<SortableContainer>
{ !! fields && fields.map( ( field, index ) => {
	return (
		<SortableItem
			key={ `item-${ index }` }>
			{ props.children }
		</SortableItem>
	);
},
) }
</SortableContainer>

And inside our Sortable Item:

<SlotFillProvider>			
  { render }
  <div className={ cls.elem( 'controls' ).toString() }>
	  <Slot name={ 'repeaterControls' } />
  </div>
</SlotFillProvider>

Is this a bug? Did something change in the Slotfill package or somewhere else that would explain this change in behaviour? Again, we haven't changed anything at all in our codebase regarding these items between 6.3.2 and 6.4.1, so any help would be appreciated.

Step-by-step reproduction instructions

Make a slotfill inside a looped item?

Screenshots, screen recording, code snippet

No response

Environment info

No response

Please confirm that you have searched existing issues in the repo.

Yes

Please confirm that you have tested with all plugins deactivated except Gutenberg.

No

Metadata

Metadata

Assignees

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions