-
Notifications
You must be signed in to change notification settings - Fork 4.6k
Description
Right now, if you enable lightbox for an image and then add a link, the lightbox behavior is disabled, breaking user expectations. We need to clarify this experience as right now these behaviors are interconnected but that isn't clear.
"Expand on click" should be designed and optimized for as something that you enable once, globally, and then optionally override on a per-image or gallery basis. In following this approach, it would make sense to move the toggle from the inspector and into the URL toolbar. In doing so, it becomes more intuitively clear that "Expand on click" is mutually exclusive from linking to an attachment page, or a media file.
This design also leverages concepts outlined for the Link Control in #50891.
Separately, for when applying lightbox through a singular action across images in a gallery, the same dropdown that is currently used for linking to attachment or media files would be used:
See also: #56587 for conversations on the expand behavior as applied in galleries.
Issue updated Dec 22.
Previous version of the issue
Right now, if you enable lightbox for an image and then add a link, the lightbox behavior is disabled, breaking user expectations. We need to clarify this experience as right now these behaviors are interconnected but that isn't clear. Here's an example where you can enable lightbox and add a link but that then silently breaks lightbox behavior:
lightbox.mov
@jasmussen can you look into mapping this out? It seems like if you have lightbox enabled, we should disable the ability to add a link or consider a way to group these settings together since they interrelate.
Feel free to edit the title of this issue as it's a bit rough.