-
Notifications
You must be signed in to change notification settings - Fork 4.5k
Open
Labels
[Block] ImageAffects the Image BlockAffects the Image Block[Feature] Interactivity APIAPI to add frontend interactivity to blocks.API to add frontend interactivity to blocks.[Type] EnhancementA suggestion for improvement.A suggestion for improvement.
Description
The following shorthand syntaxes are currently filtered out when specified in theme.json
, so we are unable to use them for configuring the lightbox:
"settings": {
"lightbox": true
}
"settings": {
"blocks": {
"core/image": {
"lightbox": true
}
}
}
Presumably, these would be shorthand for the following:
"settings": {
"lightbox": {
"enabled": false,
"allowEditing": true
}
}
"settings": {
"blocks": {
"core/image": {
"lightbox": {
"enabled": false,
"allowEditing": true
}
}
}
}
The following values are likewise filtered out:
"settings": {
"lightbox": false
}
"settings": {
"blocks": {
"core/image": {
"lightbox": false
}
}
}
These could be shorthand for the following:
"settings": {
"lightbox": {
"enabled": false,
"allowEditing": false
}
}
"settings": {
"blocks": {
"core/image": {
"lightbox": {
"enabled": false,
"allowEditing": false
}
}
}
}
We should determine what needs to change in the codebase to allow for this shorthand syntax, determine what the behavior should be, decide whether we should indeed support the shorthand syntax or not and, if so, implement.
Metadata
Metadata
Assignees
Labels
[Block] ImageAffects the Image BlockAffects the Image Block[Feature] Interactivity APIAPI to add frontend interactivity to blocks.API to add frontend interactivity to blocks.[Type] EnhancementA suggestion for improvement.A suggestion for improvement.