-
Notifications
You must be signed in to change notification settings - Fork 4.5k
Closed
Labels
[Feature] Site EditorRelated to the overarching Site Editor (formerly "full site editing")Related to the overarching Site Editor (formerly "full site editing")[Focus] Accessibility (a11y)Changes that impact accessibility and need corresponding review (e.g. markup changes).Changes that impact accessibility and need corresponding review (e.g. markup changes).[Status] In ProgressTracking issues with work in progressTracking issues with work in progress[Type] BugAn existing feature does not function as intendedAn existing feature does not function as intended
Description
- Makes use of regular modal patterns (title, close button, bottom-actions).
- Actions are sticky at the bottom of the modal. This may require a component-level update.
- Current context highlighted above all other changes.
Original issue
In the lead up to the 6.2 release a global save button was added to the site editor. Clicking it invokes the following modal:This is a essentially a clone of the multi-entity save panel, presented in a modal. It needs to retain the same functionality of course, but the design needs some refinement.
If we stick with the modal approach then it seems reasonable to at least use conventional anatomy (title, close button, actions at the bottom, etc), and be more accessible (#47885). There might be different formats to explore for the contents as well.
I don't know how committed we are to the modal, it could also be worth exploring other options like drilldowns.
Mamaduka and annezazu
Metadata
Metadata
Assignees
Labels
[Feature] Site EditorRelated to the overarching Site Editor (formerly "full site editing")Related to the overarching Site Editor (formerly "full site editing")[Focus] Accessibility (a11y)Changes that impact accessibility and need corresponding review (e.g. markup changes).Changes that impact accessibility and need corresponding review (e.g. markup changes).[Status] In ProgressTracking issues with work in progressTracking issues with work in progress[Type] BugAn existing feature does not function as intendedAn existing feature does not function as intended
Type
Projects
Status
Needs dev
Status
Done
Status
Done
Status
✅ Done