Skip to content

Series of bugs and shortcomings faced during 5.9 go/no go prep #35662

@mtias

Description

@mtias

Compiling a list of bugs, shortcomings, and enhancement ideas I run into when preparing for the go / no go demo.

There's a lot of small issues related to the roundtrip a ServerRender block needs to do for any change and a great showcase for why they should be avoided entirely for any interactive block.

Screeny.Video.14.Oct.2021.at.12.29.46.mov
Screeny.Video.14.Oct.2021.at.18.41.39.mov
  • Navigation block new link would break with no visible signs of recovery — typing the name of the page would not bring the page up.

Generally can happen after leaving the page open for a little bit or interacting for a while. It's understandable connection might break, but there should be some feedback.

Screeny.Video.13.Oct.2021.at.20.28.05.mov

image

  • Buttons inside groups are misaligned. (Might be theme related.)

image

  • Disabling theme editor styles in preferences makes some elements in the page load with default colors and not the current color scheme.

image

  • The sibling inserter repositioning, together with the animation, makes it jump around.
Screeny.Video.14.Oct.2021.at.18.31.43.mov

  • The amount of lines shown in the site editor to distinguish active focus, hover focus, current template part focus, etc, is wild. We need to reduce this.

image

  • There's also a weird dotted outline on the site block.

image

  • More blocks with dotted outlines that don't seem appropriate.

image

  • Search in navigation menus is super awkward. It should be possible to get an icon only button that expands inline or in an overlay. This should likely also be the default. The initial insertion state, in particular, is a terrible experience (Search: Hide label when inserted in Navigation block #36026):

image

  • Menu settings (called Display) should come before the Typography supports and should probably not be in a panel at all (not collapsible).

  • Typography: default size looks "unset".

image

Metadata

Metadata

Assignees

No one assigned

    Labels

    [Feature] ThemesQuestions or issues with incorporating or styling blocks in a theme.[Type] BugAn existing feature does not function as intended[Type] EnhancementA suggestion for improvement.[Type] Tracking IssueTactical breakdown of efforts across the codebase and/or tied to Overview issues.

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions