Skip to content

ToolsPanel: move away from hardcoded classnames #35058

@ciampo

Description

@ciampo

What

Requires #34345 first, to make sure that tests don't rely on classnames.

We should refactor the ToolsPanel component so that it avoids using hardcoded classnames as much as possible.

Currently, the hardcoded classnames in TooolsPanel are:

Why

We should avoid using hardcoded classnames as much as possible in our components:

  • it goes against the Styling guidelines, where classnames are generated at runtime
  • hardcoded classnames can be effectively treated as public API, which can later need to involuntary breaking changes later on.

A/C

  • Remove the components-tools-panel classname
  • Remove the single-column classname
  • Remove the components-dropdown-menu and components-dropdown-menu__toggle classnames

Metadata

Metadata

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions