-
Notifications
You must be signed in to change notification settings - Fork 4.5k
Open
Labels
Backwards CompatibilityIssues or PRs that impact backwards compatabilityIssues or PRs that impact backwards compatability[Feature] Link EditingLink components (LinkControl, URLInput) and integrations (RichText link formatting)Link components (LinkControl, URLInput) and integrations (RichText link formatting)[Package] Block editor/packages/block-editor/packages/block-editor[Type] TaskIssues or PRs that have been broken down into an individual action to takeIssues or PRs that have been broken down into an individual action to take
Description
Previously: #18061 (comment)
As discussed in #18061, the new LinkControl
component can be considered as a composite component of URLInput
, plus labeling behaviors associated with similar *Control
input control components.
Diagram (not including label):
In this model, URLInput
should be considered a very barebones component whose sole responsibility should be to render an input field and associated URL autocompletion results from which to pick a value.
This component would not accept a label
prop. However, since URLInput
already does accept label
, we should soft-deprecate it in the following manner:
- Continue to accept
label
- If
label
is provided:- Log a
deprecated
message - Render
<LinkControl />
with the givenlabel
and relevant propsLinkControl
will recursively renderURLInput
, but it should not passlabel
, thus avoiding recursion
- Log a
Metadata
Metadata
Assignees
Labels
Backwards CompatibilityIssues or PRs that impact backwards compatabilityIssues or PRs that impact backwards compatability[Feature] Link EditingLink components (LinkControl, URLInput) and integrations (RichText link formatting)Link components (LinkControl, URLInput) and integrations (RichText link formatting)[Package] Block editor/packages/block-editor/packages/block-editor[Type] TaskIssues or PRs that have been broken down into an individual action to takeIssues or PRs that have been broken down into an individual action to take