Skip to content

More menu "feature toggle" invalid HTML #13903

New issue
New issue
Closed
Closed
More menu "feature toggle" invalid HTML#13903
Labels
Good First IssueAn issue that's suitable for someone looking to contribute for the first time[Type] BugAn existing feature does not function as intended[Type] Code QualityIssues or PRs that relate to code quality
@afercia

Description

@afercia
afercia
opened on Feb 16, 2019

Noticed while reviewing #13059

The FeatureToggle component renders a label HTML attribute, which is invalid HTML. Seems to me the label prop should only be used as children and not passed as a prop to MenuItem:

gutenberg/packages/edit-post/src/components/header/feature-toggle/index.js

Lines 23 to 33 in 0f18024

return (
<MenuItem
icon={ isActive && 'yes' }
isSelected={ isActive }
onClick={ flow( onToggle, speakMessage ) }
role="menuitemcheckbox"
label={ label }
info={ info }
>
{ label }
</MenuItem>

otherwise, it gets rendered as an HTML attribute (which doesn't do anything other than invalidating the HTML):

screenshot 2019-02-16 at 20 02 25

Metadata

Metadata

Assignees

No one assigned

    Labels

    Good First IssueAn issue that's suitable for someone looking to contribute for the first time[Type] BugAn existing feature does not function as intended[Type] Code QualityIssues or PRs that relate to code quality

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions