-
Notifications
You must be signed in to change notification settings - Fork 4.5k
Closed
Labels
[Type] BugAn existing feature does not function as intendedAn existing feature does not function as intended
Description
Describe the bug
Left or right aligned blocks may have hidden move controls if it floated. This looks intentionally added in #10085.
Could be related to #12290
To Reproduce
Steps to reproduce the behavior:
- Create a pull quote block.
- Left or right align the pull quote block.
- Attempt to drag or move the pull quote block.
Expected behavior
Expected the mover controls to be visible when hovering over the pull quote block.
Screenshots
If applicable, add screenshots to help explain your problem.
Initial Investigation
- While a non floated block pull-quote has a class="editor-block-mover is-visible" the block controls display as expected.
- While a pull quote block is floated left or right and has class="editor-block-mover is-visible" the block move controls are hidden. This is caused by an overflow on the parent container.
//editor/style.css line 349
.editor-block-list__layout .editor-block-list__block[data-align="left"] .editor-block-mover, .editor-block-list__layout .editor-block-list__block[data-align="left"] .editor-block-list__block-mobile-toolbar, .editor-block-list__layout .editor-block-list__block[data-align="right"] .editor-block-mover, .editor-block-list__layout .editor-block-list__block[data-align="right"] .editor-block-list__block-mobile-toolbar {
display: none;
}
Turning off display none will display the block menu controls. However, the controls disappear while visible for the paragraph block that the pull quote is floated around.
You can get the block working properly again by changing left: -30px
to `left: 0;'. However, the movement controls will display in an awkward place.
.editor-block-list__block > .editor-block-mover {
padding-right: 2px;
// left: -30px;
left: 0; // moves the block back in the container.
display: none;
}
Metadata
Metadata
Assignees
Labels
[Type] BugAn existing feature does not function as intendedAn existing feature does not function as intended