-
Notifications
You must be signed in to change notification settings - Fork 4.5k
Closed
Labels
[Feature] HistoryHistory, undo, redo, revisions, autosave.History, undo, redo, revisions, autosave.[Type] BugAn existing feature does not function as intendedAn existing feature does not function as intended[Type] Code QualityIssues or PRs that relate to code qualityIssues or PRs that relate to code quality
Description
Right now, if we edit blocks, the history (undo/redo) is kept in the redux store using the withHistory
higher-order reducer. But only the blocks
substate is kept in the history while the block selection is not. Which means if we trigger undo/redo we can potentially end up with a state tree where the blockSelection points to a non-existing block. (For example a block that was removed by undoing a change).
We should explore whether moving the block selection reducer inside the withHistory
Higher-order reducer could solve these issues and which side-effects it would have on the undo/redo behavior.
Related #12214
mcsf
Metadata
Metadata
Assignees
Labels
[Feature] HistoryHistory, undo, redo, revisions, autosave.History, undo, redo, revisions, autosave.[Type] BugAn existing feature does not function as intendedAn existing feature does not function as intended[Type] Code QualityIssues or PRs that relate to code qualityIssues or PRs that relate to code quality